Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indicator footer buttons render conditions #856

Conversation

allan-chagas-brisa
Copy link
Contributor

Issue Number

fix #850

Proposed Changes

To achieve the validation necessary without changing the whole indicator types structure, only changes in the html were made.

  • changed the logic in the indicator footer buttons;
  • now it will render the open popover button only if the popover config is informed, not necessarily only depending of the button type.

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

@iurynogueira iurynogueira merged commit 5547c67 into main Oct 3, 2023
3 checks passed
@iurynogueira iurynogueira deleted the 850-fix-conditionate-mandatory-attributes-on-button-config-from-indicator branch October 3, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: conditionate mandatory attributes on button config from indicator
3 participants